alephdata / memorious

Lightweight web scraping toolkit for documents and structured data.
https://docs.alephdata.org/developers/memorious
MIT License
311 stars 59 forks source link

fetch should ignore mailto links #128

Closed rhiaro closed 4 years ago

rhiaro commented 4 years ago

There's no case where we'd want to try to fetch mailto links is there? Would be handy to have fetch ignore these out of the box.

pudo commented 4 years ago

I guess we could even make this a whitelist instead: all we really understand is http, https and "nothing" (which probably implies Http) as the URL scheme.

rhiaro commented 4 years ago

makes sense - ftp and webdav are covered by other operations than fetch

sunu commented 4 years ago

Fixed in https://github.com/alephdata/memorious/commit/8965892c5ee685b0b9f3a38cb6c4bca4713536f5