alephium / alephium-frontend

A monorepo containing all things frontend on Alephium.
Other
13 stars 10 forks source link

Discuss: Allow user to change password #56

Open nop33 opened 1 year ago

nop33 commented 1 year ago

As @MaudSimon mentioned in https://github.com/alephium/desktop-wallet/pull/557#issuecomment-1458064102, users are requesting the ability to change their password. Currently, the only way to do that is:

  1. Import the mnemonic to a new wallet
  2. Delete old wallet

TBD

mvaivre commented 1 year ago

Thanks for opening this issue. This is obviously something to consider carefully. Let's try to see what others do :)

  1. Metamask has a "forgot your password" button. It's basically a shortcut for deleting the wallet and reimporting it.
  2. Argent X doesn't allow changing the password.
  3. Firefly allows to update the pin.
  4. We can check some other wallets, I started with the ones I have around.

The easy way is the metamask way. We could add a "forgot your password" button, which triggers the import flow. The previous wallet is deleted after the mnemonic is entered. Same as Metamask, we should add a big disclaimer explaining what this process does. This reset is used wether the password has been forgotten or not.

Now, a better UX would be to actually allow updating the password (if the old password is known), without reimporting everything. User would need to re-enter the mnemonic and the previous password to proceed to the update. This would require a re-encryption of the local storage files : I'm curious to discuss the downsides of this approach.

nop33 commented 1 year ago

@mvaivre , as you mentioned, this could be split into 2 tasks:

  1. Forgot password
  2. Change password
nop33 commented 5 months ago

This is still a good idea to implement. I would focus on the "Forgot password" rather than the "Change password". Forgot password would be a shortcut to the following operations:

  1. User enters their 24 words
  2. User enters new password
  3. Old wallet gets deleted