search

alephium / alephium-nft

Prototype for NFT Marketplace on Alephium
6 stars 7 forks source link

Add my-collections page #25

Closed Lbqds closed 1 year ago

h0ngcha0 commented 1 year ago

Question: in the My Collection page, is the intention to list all collection I created, or collection of the NFTs that I currently own, or both?

Lbqds commented 1 year ago

Question: in the My Collection page, is the intention to list all collection I created, or collection of the NFTs that I currently own, or both?

Only I created collections for now, but we can also support the second one.

h0ngcha0 commented 1 year ago

Question: in the My Collection page, is the intention to list all collection I created, or collection of the NFTs that I currently own, or both?

Only I created collections for now, but we can also support the second one.

That would be great. Since if I bought an NFT, I would probably expect to see it in my collections.

I am actually a bit unclear about if we click on the collection in my collection, shall we see all NFTs within that collection or only my NFTs in that collection. WDTY?

Another question is if we have my collection tab, do we still need my nft tab?

Lbqds commented 1 year ago

I am actually a bit unclear about if we click on the collection in my collection, shall we see all NFTs within that collection or only my NFTs in that collection. WDTY?

Currently we can see all NFTs because it just redirects to the collection-details page, perhaps we can refer to Opensea's approach. I will check it later.

Another question is if we have my collection tab, do we still need my nft tab?

I was hesitant before, but I think users might want to see my nfts directly, so I kept it for now.

h0ngcha0 commented 1 year ago

I am actually a bit unclear about if we click on the collection in my collection, shall we see all NFTs within that collection or only my NFTs in that collection. WDTY?

Currently we can see all NFTs because it just redirects to the collection-details page, perhaps we can refer to Opensea's approach. I will check it later.

Another question is if we have my collection tab, do we still need my nft tab?

I was hesitant before, but I think users might want to see my nfts directly, so I kept it for now.

If feels like if we only show user's own NFT when clicking the collection in My Collection tab, then we might not need the My NFT page, since they are basically two views of the same info.

h0ngcha0 commented 1 year ago

Close since everything is in https://github.com/alephium/alephium-nft/pull/28 now