search

alephium / alephium-nft

Prototype for NFT Marketplace on Alephium
6 stars 7 forks source link

More Secure Collection Id #36

Closed h0ngcha0 closed 1 year ago

h0ngcha0 commented 1 year ago

There is a corresponding PR for SDK.

If the new interface methods look ok, will merge SDK and update this PR again.

polarker commented 1 year ago

In shared/nft.ts, we use parentId for collection id, now we should remove that.

h0ngcha0 commented 1 year ago

In shared/nft.ts, we use parentId for collection id, now we should remove that.

Some NFTs might not have collection ids, but they still comply with the NFT interfaces (std id #0003), shall we fetch collection id from NFT directly and then fall back to parent if not available?