alephium / desktop-wallet

The official Alephium wallet for desktop
https://alephium.org
GNU Lesser General Public License v3.0
78 stars 44 forks source link

Metadata sync across wallets #183

Open mvaivre opened 2 years ago

mvaivre commented 2 years ago

Is your feature request related to a problem? Please describe. Metadata aren't shared across wallets: address labels and colors, contact list etc.

Describe the solution you'd like I'd like to be able to easily sync metadata between my wallets.

Describe alternatives you've considered Manually recreating metadata... which would be a pain.

Some initial ideas We could offer :

Feel free to add elements to this list. Looking forward to your feedback.

lf94 commented 2 years ago

I like the first option the most, but we can iterate with cloud backup or even storing settings on the blockchain (in that order probably).

mvaivre commented 2 years ago

Adding the sesame team to the discussion! Welcome guys 🙌 @gilles-hemmerle @olivierb2

Both our teams would benefit from a flexible metadata storing solution, so let's brainstorm a bit.

LeeAlephium commented 2 years ago

I think we could offer both the file export and WalletConnect transfer. The WC transfer could have a rogue WC entity which is capturing everyone's data, so that's a concern. I wouldn't recommend it in high risk cases but for everything else we can... and I think it'd be great UX. Imagine being able to just transfer your desktop wallet to phone via a simple picture... I don't know anyone which is doing this.

mvaivre commented 2 years ago

This sounds good yeah! A "sync accounts" a la Whatsapp web.

nop33 commented 2 years ago

The WC transfer could have a rogue WC entity which is capturing everyone's data, so that's a concern.

Not sure exactly how WC internally works, but we could encrypt the data using the seed. Since the seed is available on the other devices, it would be able to decrypt the data and WC knows nothing at the end.

Imagine being able to just transfer your desktop wallet to phone via a simple picture

Hm, this would require the seed to be transfered through WC, which doesn't sound like a good idea. Unless of course we have a button in the desktop wallet that creates a QR code of the mnemonic so that the mobile wallet can scan it and import it. Together with this QR code we could attach the metadata. No WalletConnect in between. This could be done completely offline. The desktop shows a QR code, you scan it with your phone, wallet gets imported and metadata copied. No internet required. We anyway expose the mnemonic to the user through the user settings, why not a QR code as well for easy transition to the mobile wallet?

Then, of course, the metadata would live in 2 different wallets and managed separately, but that's fine and expected.

mvaivre commented 2 years ago

Just FYI, I've been experimenting with QR codes a bit. I've been able to store quite big JSON object as a code, and scan it very easily with my phone.

We could use this kind of offline transfer of info to share metadata, and/or to ease the storing / importing of mnemonic. I'll create some concepts around that idea.

mvaivre commented 1 year ago

Idea to transmit more info (metadata): successive QR codes being shown in a sequence, as Ledger does it.

nop33 commented 10 months ago

@mvaivre now that we have the "import from desktop wallet" feature in the mobile wallet, do you think this issue is still relevant?