search

alephium / desktop-wallet

The official Alephium wallet for desktop
https://alephium.org
GNU Lesser General Public License v3.0
79 stars 44 forks source link

Walletconnect: auto connect #794

Open Lbqds opened 1 year ago

Lbqds commented 1 year ago

The branch for the @alephium/web3 is here: https://github.com/alephium/alephium-web3/pull/270

When testing with npm run start:electron, please be mindful NOT to use CTRL + C to shutdown the client. Electron won't persist localStorage in this case. And I tried process.on('exit', () => app.quit()), but it still does not work.

nop33 commented 1 year ago

Thanks for this PR @Lbqds!

As per request from the community I've implemented in my PR #802 the feature of handling multiple WalletConnect sessions. This includes initializing the app state with the current active WalletConnect sessions, derived from the client. I believe this covers the use case of this PR as well, so I believe it's not needed anymore.

Let me know if you think differently!

Lbqds commented 1 year ago

Great work👍, feel free to close it if it's not needed!

nop33 commented 1 year ago

I think I'll keep it open until the new desktop wallet version is released, then we can test together to verify that the requirements of this PR are met 😉