Apply routing fixes in browser

[ali9821]

List of bugs : 1.Adding chackra-cli in packages.json

• error :
• solution : 2.Routing in browser has a bug that on refresh the app lose the route
• bug : it has problem with
• solution : replace it with 3.You have error with imported from @argent
• solution : import from react-router-dom

[polarker]

@ali9821 Thanks for the report. We will check tomorrow. cc @h0ngcha0

[ali9821]

Yes sure I tested with version 2.4.0 and it was more compatible than 2.4.1 Also look at the other fixes I sent in the description they're important too

On Tue, Jan 23, 2024, 03:06 Hongchao Liu @.***> wrote:

@.**** commented on this pull request.

In package.json https://github.com/alephium/extension-wallet/pull/179#discussion_r1462556210 :

@@ -14,7 +14,8 @@ "patch-package": "^6.4.7", "prettier": ">=2", "prettier-plugin-import-sort": "^0.0.7",

• "ts-node": "^10.8.1"
• "ts-node": "^10.8.1",
• @.***/cli": "^latest"

Thanks for the fix! 👍 Can we set an explicit version here instead of latest?

— Reply to this email directly, view it on GitHub https://github.com/alephium/extension-wallet/pull/179#pullrequestreview-1837599445, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT2YFTPUPOO2XGSH3A3L32LYP3ZYRAVCNFSM6AAAAABCDE346SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMZXGU4TSNBUGU . You are receiving this because you were mentioned.Message ID: @.***>

[h0ngcha0]

Yes sure I tested with version 2.4.0 and it was more compatible than 2.4.1 Also look at the other fixes I sent in the description they're important too

Thanks!

[ali9821]

When you extend the extension in the browser when You refresh the page, the program can't get the account/tokens route and user get lost you can try with extending wallet in browser and refreshing the page

On Tue, Jan 23, 2024, 14:32 Hongchao Liu @.***> wrote:

@.**** commented on this pull request.

In packages/extension/src/ui/index.tsx https://github.com/alephium/extension-wallet/pull/179#discussion_r1463100501 :

@@ -33,8 +33,8 @@ const root = createRoot(container)

root.render(

- + Routing in browser has a bug that on refresh the app lose the route Could you please give me a bit more info about the issue? Do you mean refreshing the extension wallet? — Reply to this email directly, view it on GitHub , or unsubscribe . You are receiving this because you were mentioned.Message ID: ***@***.***>

[ali9821]

You get an error in the code And I remember some time ago when you were changing the route and was getting redirected to some pages the components didn't load and the page was blank

On Tue, Jan 23, 2024, 14:28 Hongchao Liu @.***> wrote:

@.**** commented on this pull request.

In packages/extension/src/ui/AppRoutes.tsx https://github.com/alephium/extension-wallet/pull/179#discussion_r1463095280 :

import { chakra } from @.***/react" import { FC, ReactNode, isValidElement, useMemo } from "react" // import { Outlet, Route, Routes } from "react-router-dom" // reinstate in case of issues with @argent/stack-router import { Outlet, useLocation } from "react-router-dom" +import {Routes} from "react-router-dom" // import Routes from react-router-dom

You have error with imported from @Argent https://github.com/Argent

What kind of error did you get with importing Routes from @.***/stack-router"?

— Reply to this email directly, view it on GitHub https://github.com/alephium/extension-wallet/pull/179#pullrequestreview-1838469592, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT2YFTMNUID26T23FG4PHK3YP6JVVAVCNFSM6AAAAABCDE346SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMZYGQ3DSNJZGI . You are receiving this because you were mentioned.Message ID: @.***>

[h0ngcha0]

When you extend the extension in the browser when You refresh the page, the program can't get the account/tokens route and user get lost you can try with extending wallet in browser and refreshing the page … On Tue, Jan 23, 2024, 14:32 Hongchao Liu @.> wrote: @*.*** commented on this pull request. ------------------------------ In packages/extension/src/ui/index.tsx <#179 (comment)> : > @@ -33,8 +33,8 @@ const root = createRoot(container) root.render( - + Routing in browser has a bug that on refresh the app lose the route Could you please give me a bit more info about the issue? Do you mean refreshing the extension wallet? — Reply to this email directly, view it on GitHub <#179 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT2YFTNFSJSY577Z6YJQLALYP6KFPAVCNFSM6AAAAABCDE346SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMZYGQ3TONJRGA . You are receiving this because you were mentioned.Message ID: @.>

Tested it, nice fix :+1:

[h0ngcha0]

You get an error in the code And I remember some time ago when you were changing the route and was getting redirected to some pages the components didn't load and the page was blank … On Tue, Jan 23, 2024, 14:28 Hongchao Liu @.> wrote: @*.*** commented on this pull request. ------------------------------ In packages/extension/src/ui/AppRoutes.tsx <#179 (comment)> : > import { chakra } from @./react" import { FC, ReactNode, isValidElement, useMemo } from "react" // import { Outlet, Route, Routes } from "react-router-dom" // reinstate in case of issues with @argent/stack-router import { Outlet, useLocation } from "react-router-dom" +import {Routes} from "react-router-dom" // import Routes from react-router-dom You have error with imported from @Argent https://github.com/Argent What kind of error did you get with importing Routes from @./stack-router"? — Reply to this email directly, view it on GitHub <#179 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT2YFTMNUID26T23FG4PHK3YP6JVVAVCNFSM6AAAAABCDE346SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMZYGQ3DSNJZGI . You are receiving this because you were mentioned.Message ID: @.>

How do I reproduce this error in the code? The import works ok for me so I wanna figure out a way to verify your fix.

Steps i use to build:

yarn
yarn run build

[ali9821]

Ok, I'll look into it.

On Thu, Jan 25, 2024, 15:07 Hongchao Liu @.***> wrote:

You get an error in the code And I remember some time ago when you were changing the route and was getting redirected to some pages the components didn't load and the page was blank … <#m_4494558921543832491_m6063890652486066888> On Tue, Jan 23, 2024, 14:28 Hongchao Liu @.*> wrote: @.* commented on this pull request. ------------------------------ In packages/extension/src/ui/AppRoutes.tsx <#179 (comment) https://github.com/alephium/extension-wallet/pull/179#discussion_r1463095280> : > import { chakra } from @./react" import { FC, ReactNode, isValidElement, useMemo } from "react" // import { Outlet, Route, Routes } from "react-router-dom" // reinstate in case of issues with @argent/stack-router import { Outlet, useLocation } from "react-router-dom" +import {Routes} from "react-router-dom" // import Routes from react-router-dom You have error with imported from @Argent https://github.com/Argent https://github.com/Argent https://github.com/Argent What kind of error did you get with importing Routes from @./stack-router"? — Reply to this email directly, view it on GitHub <#179 (review) https://github.com/alephium/extension-wallet/pull/179#pullrequestreview-1838469592>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT2YFTMNUID26T23FG4PHK3YP6JVVAVCNFSM6AAAAABCDE346SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMZYGQ3DSNJZGI . You are receiving this because you were mentioned.Message ID: @*.***>

How do I reproduce this error in the code? The import works ok for me so I wanna figure out a way to verify your fix.

Steps i use to build:

yarn yarn run build

— Reply to this email directly, view it on GitHub https://github.com/alephium/extension-wallet/pull/179#issuecomment-1909992737, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT2YFTI76VVXXBUCJ2VJCXDYQI7WTAVCNFSM6AAAAABCDE346SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBZHE4TENZTG4 . You are receiving this because you were mentioned.Message ID: @.***>

[ali9821]

You're welcome

On Thu, Jan 25, 2024, 15:04 Hongchao Liu @.***> wrote:

When you extend the extension in the browser when You refresh the page, the program can't get the account/tokens route and user get lost you can try with extending wallet in browser and refreshing the page … <#m2036684164093062916> On Tue, Jan 23, 2024, 14:32 Hongchao Liu @.*> wrote: @.* commented on this pull request. ------------------------------ In packages/extension/src/ui/index.tsx <#179 (comment) https://github.com/alephium/extension-wallet/pull/179#discussion_r1463100501> : > @@ -33,8 +33,8 @@ const root = createRoot(container) root.render( - + Routing in browser has a bug that on refresh the app lose the route Could you please give me a bit more info about the issue? Do you mean refreshing the extension wallet? — Reply to this email directly, view it on GitHub <#179 (review) https://github.com/alephium/extension-wallet/pull/179#pullrequestreview-1838477510>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT2YFTNFSJSY577Z6YJQLALYP6KFPAVCNFSM6AAAAABCDE346SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMZYGQ3TONJRGA . You are receiving this because you were mentioned.Message ID: @*.***>

Tested it, nice fix 👍

— Reply to this email directly, view it on GitHub https://github.com/alephium/extension-wallet/pull/179#issuecomment-1909986017, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT2YFTJ5UPZUVUQ7Q4JSGOTYQI7LPAVCNFSM6AAAAABCDE346SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBZHE4DMMBRG4 . You are receiving this because you were mentioned.Message ID: @.***>

[ali9821]

BTW do you need any Web3 Frontend dev in your team?

On Thu, Jan 25, 2024, 15:29 Ali Azarian @.***> wrote:

You're welcome

On Thu, Jan 25, 2024, 15:04 Hongchao Liu @.***> wrote:

When you extend the extension in the browser when You refresh the page, the program can't get the account/tokens route and user get lost you can try with extending wallet in browser and refreshing the page … <#m_591274396940063359_m2036684164093062916> On Tue, Jan 23, 2024, 14:32 Hongchao Liu @.*> wrote: @.* commented on this pull request. ------------------------------ In packages/extension/src/ui/index.tsx <#179 (comment) https://github.com/alephium/extension-wallet/pull/179#discussion_r1463100501> : > @@ -33,8 +33,8 @@ const root = createRoot(container) root.render( - + Routing in browser has a bug that on refresh the app lose the route Could you please give me a bit more info about the issue? Do you mean refreshing the extension wallet? — Reply to this email directly, view it on GitHub <#179 (review) https://github.com/alephium/extension-wallet/pull/179#pullrequestreview-1838477510>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT2YFTNFSJSY577Z6YJQLALYP6KFPAVCNFSM6AAAAABCDE346SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMZYGQ3TONJRGA . You are receiving this because you were mentioned.Message ID: @*.***>

Tested it, nice fix 👍

— Reply to this email directly, view it on GitHub https://github.com/alephium/extension-wallet/pull/179#issuecomment-1909986017, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT2YFTJ5UPZUVUQ7Q4JSGOTYQI7LPAVCNFSM6AAAAABCDE346SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBZHE4DMMBRG4 . You are receiving this because you were mentioned.Message ID: @.***>

[h0ngcha0]

BTW do you need any Web3 Frontend dev in your team? … On Thu, Jan 25, 2024, 15:29 Ali Azarian @.> wrote: You're welcome On Thu, Jan 25, 2024, 15:04 Hongchao Liu @.> wrote: > When you extend the extension in the browser when You refresh the page, > the program can't get the account/tokens route and user get lost you can > try with extending wallet in browser and refreshing the page > … <#m_591274396940063359_m2036684164093062916> > On Tue, Jan 23, 2024, 14:32 Hongchao Liu @.*> wrote: @. commented on > this pull request. ------------------------------ In > packages/extension/src/ui/index.tsx <#179 (comment) > <#179 (comment)>> > : > @@ -33,8 +33,8 @@ const root = createRoot(container) root.render( - + > Routing in browser has a bug that on refresh the app lose the route Could > you please give me a bit more info about the issue? Do you mean refreshing > the extension wallet? — Reply to this email directly, view it on GitHub <#179 > (review) > <#179 (review)>>, > or unsubscribe > https://github.com/notifications/unsubscribe-auth/AT2YFTNFSJSY577Z6YJQLALYP6KFPAVCNFSM6AAAAABCDE346SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMZYGQ3TONJRGA > . You are receiving this because you were mentioned.Message ID: @.**> > > Tested it, nice fix 👍 > > — > Reply to this email directly, view it on GitHub > <#179 (comment)>, > or unsubscribe > https://github.com/notifications/unsubscribe-auth/AT2YFTJ5UPZUVUQ7Q4JSGOTYQI7LPAVCNFSM6AAAAABCDE346SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBZHE4DMMBRG4 > . > You are receiving this because you were mentioned.Message ID: > @.> >

AFAIK, not at the moment, might change in the future. We do have a grant program in case you are interested.

You are welcome to join our discord channel, many dev related topics are discussed there.