Closed tdroxler closed 4 weeks ago
I didn't have time to check what was received by the server, but maybe the didOpen notification send something with an uri starting with
git///
instead of the expectedfile///
Yep, you are right. Good catch! URIUtil.getFileName
errored (stacktrace from VSCode below). It errors for all APIs: open, code-completion, go-to def etc because git
is not a supported URI yet.
This will have to be handled differently. I don't have a quick solution for this and it will need testing, specially for moved files. So temporarily, to stop that error, we can ignore processing files that do not have a file:///
scheme. WDYT?
We can ignore processing files that do not have a file:/// scheme. WDYT?
Yes, anyway I don't think ralph-lsp should handle in anyway a git:///
file. We do receive them because we tell the client we want to watch all files, we could also choose to watch only *.ral
, ralph.json
and alephium.config.ts
. The client then shouldn't send us the git files.
But It's still good to ignore other schemes, because a client could also send us something we didn't request
Weird issue in vscode when opening the Source Control tab
I could reproduce with the following:
Make a change to any contract, like just a new line.
Open the source control:
Ctrl + Shift + G
From the source control tab, click on your contract
The error should pop up.
I didn't have time to check what was received by the server, but maybe the didOpen notification send something with an uri starting with
git///
instead of the expectedfile///