Issue (also see the attached referenced issue below)
Warnings returned by ralphc have the following conditions:
Warnings can be returned within CompiledContract, CompiledScript or they can returned by genStatefulScripts().
When a Warning in a CompiledContract or CompiledScript has an empty SourceIndex or an empty SourceIndex.fileURI, it must be reported using the file information of the CompiledContract or CompiledScript containing the Warning.
A CompiledContract or CompiledScript can also contain Warnings for a file URI that is different from the CompiledContract's or CompiledScript's file information. In this case, the Warning must be reported using the file information set in the Warning itself, not the CompiledContract's or CompiledScript's file information.
Both Warning.SourceIndex and SourceIndex.fileURI are of type Option. If both are None and no file information is found for a Warning, those Warnings are logged for debugging purposes so they can be resolved in Node.
Solution
The above conditions are not as straightforward to manage. Therefore, this PR transforms the compiler output so that the above conditions are applied in the compiler-access module within RalphCompilerAccess.
Standardise
In presentation-compiler, there will only be one way to process Warnings, i.e., ALLWarnings must have their SourceIndex set and they should be returned as a single function output when contracts are compiled via compileContracts.
Issue (also see the attached referenced issue below)
Warnings returned by ralphc have the following conditions:CompiledContract,CompiledScriptor they can returned bygenStatefulScripts().Warningin aCompiledContractorCompiledScripthas an emptySourceIndexor an emptySourceIndex.fileURI, it must be reported using the file information of theCompiledContractorCompiledScriptcontaining theWarning.CompiledContractorCompiledScriptcan also containWarnings for a file URI that is different from theCompiledContract's orCompiledScript's file information. In this case, theWarningmust be reported using the file information set in theWarningitself, not theCompiledContract's orCompiledScript's file information.Warning.SourceIndexandSourceIndex.fileURIare of typeOption. If both areNoneand no file information is found for aWarning, thoseWarnings are logged for debugging purposes so they can be resolved in Node.Solution
The above conditions are not as straightforward to manage. Therefore, this PR transforms the compiler output so that the above conditions are applied in the
compiler-accessmodule withinRalphCompilerAccess.Standardise
In
presentation-compiler, there will only be one way to processWarnings, i.e., ALLWarnings must have theirSourceIndexset and they should be returned as a single function output when contracts are compiled viacompileContracts.