Fix creating dependency-injected condition

aleross / angular-segment-analytics

AngularJS module for easily adding Segment analytics to any app. https://segment.com

MIT License

43 stars 14 forks source link

Fix creating dependency-injected condition #23

Open jayellsbrg opened 7 years ago

jayellsbrg commented 7 years ago

correct Array type check
correct calculating Array's last index

coveralls commented 7 years ago

Coverage remained the same at 96.269% when pulling 2a3cdab45c41585d02489ec44d73ec08ce73638f on jayellsbrg:patch-1 into e10fb3bf74e46c8bfba604505625e5d870639c9f on aleross:master.

alinur-meltwater commented 6 years ago

Is there a reason why this PR is not being merged? We need this fix, otherwise conditions are not working. Thanks.