update brave to v1.30.87

alerque / aur

Package sources for all the AUR packages I either maintain, co-maintain, or fork.

48 stars 26 forks source link

Closed monarc99 closed 1 year ago

monarc99 commented 3 years ago

changelog:

update to 1.30.87
removed python2
disabled lto from makepkg.conf (brave/chromium uses his own version)
env didn't work (SCCACHE/COMPONENT)
disabled all system libs for COMPONENT=4 (brave crashes and patches needed to fix it - goal was to get a working version - system libs can be enabled in a later version)
removed several "" - the command to build brave is generated, the "" changed the program logic
removed old patches
removed all patches to build against gcc / libstdc++ (full clang build now with own libc++ for COMPONENT=4)
updated the chromium flags (mostly copied from the arch chromium PKGBUILD file)

monarc99 commented 3 years ago

only tested on manjaro. Not on pure arch. :)

alerque commented 3 years ago

Did you test this:

removed several "" - the command to build brave is generated, the "" changed the program logic

$ bash -c 'foo=("$(echo a b)"); for i in ${foo[@]}; do echo i=$i; done'
i=a
i=b

If it is changing the program logic then we have a bug in shellharden on our hands. But I don't think it is.

alerque commented 3 years ago

I am working on this, but build attempts take sooooooo long it is easy to wander off while they happen...