alerque / libertinus

The Libertinus font family
SIL Open Font License 1.1
979 stars 56 forks source link

Semibold 'above' and 'aboveMark' mark positioning #466

Closed kopeckyf closed 2 weeks ago

kopeckyf commented 3 years ago

This is a continuation of #426. The goal of this PR is to make mark-to-mark anchors available for some combining diacritics, and also to add anchors for some Latin glyphs that don't have reserved accented glyph slots in the Unicode table.

Goals:

New goals in 2022:

alerque commented 3 years ago

The conflicts here will need to be resolved similarly to what I just did for #467, but since the resolution will change after that PR merges I'll hold off until you consider it ready for review or that PR is merged, whichever comes first.

kopeckyf commented 2 years ago

I also corrected the above anchor for Q which was slightly off to the left.

alerque commented 2 weeks ago

Thanks for the contribution, and sorry it took so long to review. I hope I've handled the merge conflicts on this correctly. The merge conflicts should be resolved in c2d82f3 then this merged back in f188c77.

kopeckyf commented 1 week ago

Thank you very much for merging this, @alerque!

In another thread I read that there might be an alternative approach to mark placement that is more automatic and more reliable than what I have done in this PR.

@alerque, is there any plan in place for future adjustments of mark positioning in Libertinus? If I want to make more contributions, should I pursue the approach that I have taken in this PR, i.e., manual placement of anchors?

Some issues with mark placements remain in Libertinus (but I can't tell how many there are). I have a few more changes locally and I'd be happy to send a new PR for these individual improvements, too. But if there was some automatic way to place marks, I'd be happy to stop and use this alternative approach instead.