search

alerque / libertinus

The Libertinus font family
SIL Open Font License 1.1
979 stars 56 forks source link

Add {e, r} with stroke #467

Closed kopeckyf closed 2 weeks ago

kopeckyf commented 3 years ago

This PR adds missing glyphs for Latin letter e with stroke (U-0247, Wikipedia) and Latin lowercase r with stroke (U-024D, Wikipedia). Currently, these letters are only available in Serif-Regular and Serif-Bold.

kopeckyf commented 3 years ago

@alerque This is ready for your review. Nothing fancy, just a few strokes.

I tried to follow the existing design choices (e.g., in Latin lowercase c with stroke) to produce these two.

image

nsemrau commented 3 years ago

Nice work! :rocket:

For your consideration: I guess this is up to personal taste but I'd prefer the stroke through e in the bold example (and possibly other upright versions of e as well) in the middle a bit more pronounced.

I took the version from Inter font as reference:

e-stroke

I also like in the Inter version that the stroke on the below of the glyph ends more towards the middle rather the extreme left/"back" of the glyph.

moyogo commented 3 years ago

Some orthographies use ȺⱥɆɇØøꞸꞹ together. It may be better to have similar height for the diagonal strokes.

alerque commented 3 years ago

Hey sorry I've been unavailable for most font dev stuff for a while. I'll try to get this reviewed ... it seems to have run into some conflicts with the master branch, have you looked into what those are?

kopeckyf commented 3 years ago

Hey sorry I've been unavailable for most font dev stuff for a while. I'll try to get this reviewed ... it seems to have run into some conflicts with the master branch, have you looked into what those are?

Thanks! I've been busy myself but still wanted to address the comments above by nsemrau and moyogo. I hope to find time to do so in the coming days, sorry about the delay.

kopeckyf commented 3 years ago

https://github.com/alerque/libertinus/pull/467/commits/cb5f411c3e6cd8e007a578b3127be54c24b51631 has a new proposal after reviews from @moyogo and @nsemrau :

grafik

@nsemrau, I adjusted the thickness of the stroke in Semibold and Semibold-Italic

@moyogo, I tried to adjust the height of the stroke to the one in ø. However, I think that e with stroke needs a different angle for its stroke so that it can go right through the upper half ellipse of the e. Let me know if you are satisfied with the outcome.

Just to mention this for a possible future extension of the font, we seem to be missing Uni A7A5 n with stroke entirely, and Uni 2C65 a with stroke seems to need a little bit of love.

I'd be ready to have this merged as soon as everyone is satisfied.

alerque commented 2 weeks ago

Given the issue with the fork this PR was made from and my not being able to update this PR to fix merge conflicts, I had to do it on my own branch, hence GH will not reflect this properly, but this merged in 5a0c437. Thanks for the contribution!