Slack: Don't send recovery message if alert was not posted

alerta / alerta-contrib

Contributed integrations, plugins and custom webhooks

http://alerta.io

MIT License

119 stars 170 forks source link

Slack: Don't send recovery message if alert was not posted #330

Closed lotooo closed 3 years ago

lotooo commented 3 years ago

This PR avoids a slack message for recoveries if the alert itself was included in SLACK_SEVERITY_FILTER

satterly commented 3 years ago

LGTM. Did you test it? Unfortunately this plugin doesn't have any tests.

lotooo commented 3 years ago

This version is currently running on our prod setup.

I didn't tested that app.config.get('DEFAULT_NORMAL_SEVERITY') is working properly, but at least I know alerta is not broken if this is not set (we are not overriding it inside our Dockerfile).

satterly commented 3 years ago

Thanks a lot.