alerta / alerta-contrib

Contributed integrations, plugins and custom webhooks
http://alerta.io
MIT License
119 stars 170 forks source link

Can't send resolved alerts to Alerta if this plugin is installed. #331

Open burakksglu opened 3 years ago

burakksglu commented 3 years ago

Issue Summary If this plugin is installed to the Alerta side, Zabbix can't send resolved alerts for the triggers that have manual closing disabled. Alerta returns "Zabbix API doesn't allow manual closing"

Environment

To Reproduce Steps to reproduce the behavior:

  1. Create a dummy trigger in Zabbix without manual closing enabled. Do install Zabbix plugin on Alerta.
  2. Click on the ack button and don't select manual close from the update problem page.
  3. Change the threshold or trigger to auto-close the trigger. See if it succeeds.
  4. See the error.

/ ERROR: ('Zabbix: ERROR - %s', ZabbixAPIException('Error -32500: Application error., Cannot close problem: trigger does not allow manual closing.', -32500)) Aborted! / image image

Expected behavior Alerta plugin shouldn't try to go back and update the problem on Zabbix when receiving a resolved alert from Zabbix unless the user clicks the close or the ack button.

Explanation

Our configuration is like this if it's helpful

Zabbix -> Customer-Alerta(7.4.5)(Doesn't have this plugin) ->(Forward Plugin/Not Federated) -> Central Alerta(8.0.1)(Has this plugin)

So in order to solve this problem we've removed the Zabbix plugin from Customer Alerta but kept it on the Central Alerta, alerts do come after this. But we can't send an update from Central Alerta even if we add "attributes.zabbixUrl" to the alert.

lk-eska commented 2 years ago

can we do anything for this? It shouldn't try to close it back in zabbix if the close is coming from zabbix.