Add rebar 3.7.x compatibility

alertlogic / rebar_raw_resource

A rebar3 resource wrapper to accommodate non-OTP-app dependencies

Apache License 2.0

1 stars 6 forks source link

Add rebar 3.7.x compatibility #1

Closed nalundgaard closed 5 years ago

nalundgaard commented 5 years ago

Add compatibility with new resource format introduced in rebar 3.7.0 in backwards-compatible way.

zdaniel86 commented 5 years ago

my changes are not sufficient to resolve the issue. This requires much more changes :( . I haven't managed to finish it.

nalundgaard commented 5 years ago

@zdaniel86 I think I just about have it? It looks like it's working now. Could you please have a look too?

nalundgaard commented 5 years ago

Looks like I need to put this on hold. While it doesn't categorically break with this change, it looks like all of the passthrough callbacks need to be fixed in order for this to actually function as expected. What a nightmare.

sg2342 commented 5 years ago

sg2342/rebar_raw_resource@72fed2302eb7c64eea8147f62c2c1d287d120536 has a "works for me" solution for this problem.

nalundgaard commented 5 years ago

@sg2342 looks exactly what I’ve been meaning to implement, seems like it should work. What I didn’t realize on my first stab was that you have to keep the old format callbacks separate to pass through to the old format modules in rebar < 3.7, and keep the args for the new format in the new callback pass throughs. Thanks for the tip! I’ll incorporate that into this PR.

nalundgaard commented 5 years ago

@zdaniel86 @sg2342 @rmpalomino @motobob I think this is good to go now. Thanks very much to @sg2342 for the "kludge" hint (sg2342/rebar_raw_resource@72fed23); It almost worked for me. It writes a wrong lockfile, though (does not lock it as a raw file, so applying the lock, e.g. if you nuke _build, bypasses the plugin and results in a broken dep). So, I had to patch that to restore correct locking, and now it seems to be working for me.