alertlogic / rebar_raw_resource

A rebar3 resource wrapper to accommodate non-OTP-app dependencies
Apache License 2.0
1 stars 6 forks source link

Add support git_subdir resource spec #5

Closed kraysx7 closed 4 years ago

kraysx7 commented 4 years ago

Thanks for the contribution! I hadn't seen git_subdir in use yet. Have you used this in a project yet? I am curious if you've verified it and if so, how.

Yes, I checked how the plugin works in a working project. I needed to pull protobuf files from another repository from the subdirectory and build them using the gpb plugin

kraysx7 commented 4 years ago

Do you think about making a new tag (maybe 0.10.0 or 1.0.0) and publishing it in hex pm?

nalundgaard commented 4 years ago

Yes, for sure.

kraysx7 commented 4 years ago

Yes, for sure.

Thank you for your quick response! Good luck!

nalundgaard commented 4 years ago

Thank you for your quick response! Good luck!

Published 0.10.0 and added #6 to remove the maintainers property that is no longer permitted by Hex packager. Thanks again!