Add support for 8 local players

alesan99 / mari0_ae

Mari0: Alesan99's Entities

Do What The F*ck You Want To Public License

66 stars 22 forks source link

Add support for 8 local players #602

Open supersmo opened 6 months ago

supersmo commented 6 months ago

Changes:

Add support for up to 8 local players. Changing max number of players can be done by changing the value of LOCAL_PLAYERS.
Remove a redundant trailing comma when saving config.
Fixed the issue with "for some reason the number of mario colors is always 4". When updating, the old array wasn't removed so if a character was once selected which supported 4 colors then it never went back to 3 colors when switching to a character with 3 colors.

I have only tested that it works for local play on Windows.

WilliamFr0g commented 6 months ago

This doesn't account for features attuned to player number such as animations or placed portals. I'm concerned that these could be damaged in existing mappacks by using a large number of players (which could technically already happen using online multiplayer, but online breaks much more than just that, so this is not a major concern in the scheme of online issues)

supersmo commented 6 months ago

I agree, that is a concern. I don’t want to break mappacks or characters. I've tried to replicate the issues mentioned by trying a few mappacks but I haven't encountered any issues so far. Do you know of a character or mappack that is known to trigger such issues so I can better understand where it breaks?

Portals work for all players and I fixed a character bug earlier which could be related to what you describe regarding characters.

WilliamFr0g commented 4 months ago

Sorry about the late response lol

Suppose there's a placed portal entity with id 5 (usually assigned to nobody). If you're playing with 5+ people, will player 5 shooting/resetting their portals disrupt the placed portal?

With regards to animations, animations have several options which can be attuned to specific players (for example, the button pressed trigger). Does this work for all 8 players?

The later players may also spawn dangerous distances forwards into the level, which could cause them to appear inside blocks or enemies or over pits near the spawnpoint. Make sure the bonus vine cutscene doesn't have any issues with this either