search

alesan99 / mari0_ae

Mari0: Alesan99's Entities
Do What The F*ck You Want To Public License
69 stars 26 forks source link

Drop shadows on no collision/air tiles #605

Open amykaname opened 8 months ago

amykaname commented 8 months ago

I'd happily code it and make a pull request...If I knew how to The drop shadow feature still applies to non-solid tiles, which I feel like it really shouldn't Also kinda similar to #39 but I feel like straight up disabling shadows on tiles with no collision is a way simpler fix Even though this might be seen as subjective it's clearly an issue if you go in a vanilla water level with it on, as the water at the top is just non-solid tiles, which as you can see... not good image

qixils commented 3 months ago

I'm pretty sure some people will want non-solid blocks to have shadows, so #39 would be the more likely solution here IMO, especially as the hard part is actually filtering out tiles, not the process of deciding what should be filtered out

WilliamFr0g commented 2 months ago

Honestly, considering how background layer tiles don't have drop shadows, I think that exempting intangible tiles from shadows may be the better solution. The exception would be foreground tiles, which should still have them. This would help with the problem in existing mappacks that won't be updated with tile properties.

Because this problem can be mostly solved using the background layer already, which people frequently don't use to solve it, I don't think people usually put enough effort into shadows to use a property like that. And if they do, I don't know if we should encourage them to further obsess over tiny graphical flairs in an environment where so many mappacks end up unfinished anyway