Question: is pitch-detection real-time-safe?

alesgenova / pitch-detection

A collection of algorithms to determine the pitch of a sound sample.

MIT License

231 stars 27 forks source link

Question: is pitch-detection real-time-safe? #24

Open magnetophon opened 2 years ago

magnetophon commented 2 years ago

I was chatting over at the rust audio discord, and got told that get_pitch of the McLeodDetector might not be rt-safe. In particular this line was pointed out to me by @WeirdConstructor.

Is your goal for pitch-detection to be real time safe?

magnetophon commented 2 years ago

With a lot of help from the Rust Audio discord, I managed to move all allocation to new() in my fork.

It is very hacky at the moment:

made by a rust noob (me!)
needs cleanup
broken tests
broken benchmarks
no documentation

If you want, I can work on the above issues and do a PR. I'll need some guidance though, as I've just begun learning rust!