alesimula / wsa_pacman

A GUI package manager and package installer for Windows Subsystem for Android (WSA)
GNU General Public License v3.0
3.9k stars 838 forks source link

Should change text colour on blue buttons #16

Closed Kevin8675 closed 2 years ago

Kevin8675 commented 2 years ago

Currently all the buttons (install/cancel) have black text. The Install button (or any button that has a blue background) should have a more bright text (probably white) as the text is not really noticeable. image

alesimula commented 2 years ago

@Kevin8675 A different text color on an adjacent button would look weird, but I'm considering using a lighter accent color for light mode, what do you think?

image ^ Before

image ^ After

Kevin8675 commented 2 years ago

@alesimula This colour looks a lot better in my opinion.

alesimula commented 2 years ago

@Kevin8675 Here is a test version if you want to try it (the "WsaClient path" text paragraph is related to another issue I'm testing, won't be in the final version);

You can compare it to the old portable version if you want, the settings change in real time

Kevin8675 commented 2 years ago

@alesimula I just installed the test version and it looks great! Another minor design issue is that in the settings menu, the switches for autostart and icons are not lined up vertically. image Even though there is an arrow for the icons, I think the switches should line up.

alesimula commented 2 years ago

@Kevin8675 I was trying to follow the Windows settings' fluent UI choices, but I personally think it would look worse if there was a blank space after the trailing button

image

image

Kevin8675 commented 2 years ago

Ah I see, makes sense.

alesimula commented 2 years ago

@Kevin8675 change released in new version