search

alesimula / wsa_pacman

A GUI package manager and package installer for Windows Subsystem for Android (WSA)
GNU General Public License v3.0
3.82k stars 827 forks source link

[1.2.2] After sucesfully updating an app the window gives just "Cancel" as an option #33

Open akuropka opened 2 years ago

akuropka commented 2 years ago

I updated the following app through wsa_pacman: Opera beta 67.0.3485

The update succeeds, however the only option given in the final dialog was "Cancel" while one for starting the app or regular closing the window is missing. Also, I noticed that this window does not have the common options in the top right corner (Minimize, Maximize, Close).

The same happens with re-installing.

However, the issue seems to be specific as updating other apps do install as intended (however, the missing options in the top right remain).

20220114_035020_WSA-pacman 20220114_034423_WSA-pacman

https://user-images.githubusercontent.com/22570574/149443589-a6b9be8b-1602-46ec-8509-29ec4af77b73.mp4

alesimula commented 2 years ago

@akuropka I don't think the update is involved as I didn't change the logic that determines if an app should be able to be started... Though it's probably wrong, and might need to improve it (some qpps [eg. Play Services] don't have a launch activity, so I can't just always enable it)

alesimula commented 2 years ago

@akuropka BTW the installer never had window buttons and doesn't need them: you can drag/drop from any point, the cancel button acts as a close button and it can't be resized, so the lack of window buttons is on purpose

akuropka commented 2 years ago

btw is there any way to trace things by enabling debugging or logging? That would be a nice feature to follow up things...

In such cases it may be better to title the button "close" as it is not about cancelling an operation but closing the window after running it (matters not if failed or not).

I think at least a close button (X) in the top right is something every window in Windows should have following basic design.

In every case just my two cents... 😉

alesimula commented 2 years ago

@akuropka In English the buttons are "Cancel" before installation and "Dismiss" after installation, I'm noticing now they are the same on the German translation file

If you know a more appropriate term, please edit the "installer_btn_dismiss" property on the locale/de.arb file

akuropka commented 2 years ago

Okay, misinterpretation from my side, sorry. I understood "dismiss" rather for something like "discard" (e.g. saving without changes) and not "Close". Tricky world...

alesimula commented 2 years ago

@akuropka No worries :)

ShlomoCode commented 2 years ago

I think at least a close button (X) in the top right is something every window in Windows should have following basic design.

👍👍