search

alessandro-zomparelli / tissue

Tissue - Blender's add-on for computational design
1.02k stars 74 forks source link

Default Tissue version bundled with Blender 2.92.0 doesn't work #109

Open MichalStaruch opened 3 years ago

MichalStaruch commented 3 years ago

PROBLEM: Default Tissue version bundled with Blender 2.92.0 (and 2.93.0 beta) is v0.3.25 - which means even basic functions like Dual Mesh on the default cube doesn't work.

SOLUTION: I think version bundled with newer Blender (2.92.0+) should be v0.3.48 or newer - otherwise users won't be able to enjoy even basic functions of this plugin.

MichalStaruch commented 3 years ago

I didn't see any response here for over a month, so I've also reported it on the Blender side (I am not sure who updates the plugin - the addon or the Blender devs), as the problem is still there as of latest 2.93.0 build (2021-05-19): https://developer.blender.org/T88415

alessandro-zomparelli commented 3 years ago

Hi @MichalStaruch , sorry, I completely missed that issue report. It is a known issue though. I tried to get in contact with the developers, but with no success, I will try again. It's a bit annoying indeed...

MichalStaruch commented 3 years ago

@alessandro-zomparelli I talked a bit with Blender team on https://blender.chat/channel/blender-coders today, and it seems they would just need a commit from you (as the addon author) to the blender-addons repo - even straight copy of v0.3.48 into mesh_tissue folder would be OK. Something like this commit of mine: https://github.com/MichalStaruch/blender-addons/commit/1c692737e0cd0e85714b379199bda9e5270996b5, but it just needs to come from you :).

And in the future I think any changes made on the Blender repo side should be also included here, so we won't lose fixes made on the Blender side (stuff like "wiki_url" -> "doc_url" etc.) - both sides would be happy, then :).

alessandro-zomparelli commented 3 years ago

hi @MichalStaruch thank you for your help. I did send a pull request. I didn't clean the code yet, but in terms of functionalities and stability should be much better than the previous version.

robertguetzkow commented 3 years ago

@alessandro-zomparelli Sorry for chiming in, there seems to be a misunderstanding about the development process. I'm not seeing any differential on phabricator. It seems you've created a pull request on Troy's fork of the Blender mirror. Neither that repository nor the official mirror on GitHub are used for the development of Blender. The actual work happens on the Blender Foundation's git and phabricator platform. Please submit you differential there so it can be reviewed. How to submit patches is documented in our wiki. If you have any questions about the process, people on the blender-coders channel will be happy to help.

alessandro-zomparelli commented 3 years ago

Thanks @robertguetzkow , I may have done it a bit hastily. I will check more carefully the correct procedure, and in case I have some questions I will ask in the channel. Thanks :-)