search

alessandrofama / wwise-godot-integration

Wwise Integration for the Godot Engine
Other
288 stars 14 forks source link

Add Support for Distance Probes #94

Closed Snoopy20111 closed 6 months ago

Snoopy20111 commented 7 months ago

Howdy!

I recently used your implementation of Wwise in Godot for a game jam, and noticed there was no support for Distance Probes, such that 3rd person audio was sometimes a little funky. The Wwise API docs made it look pretty straightforward, so I added it myself by essentially copying the existing code for Register Listener and Register Game Object.

From my personal testing this works as expected, but I'm not deeply familiar with the Wwise API or programming for production use, so I've probably missed some error checking somewhere and haven't run any of the presumably standard tests/analysis. Additionally, I couldn't figure out how to easily get the current Listener Game Object, so I wasn't able to make custom nodes that would act as distance probes themselves.

Please consider this pull request, or otherwise just copying and fixing my code for inclusion in the next release! :)

alessandrofama commented 6 months ago

Thank you! (2+ thanks for updating the provided documentation. This should be visible in-editor in 4.3).