search

alessioalex / dynroute

Node CLI tool for dynamic DNS using Route53
46 stars 5 forks source link

Added the ability to update a wildcard domain `*` and pass multiple domains in one call #8

Closed hazanjon closed 10 years ago

hazanjon commented 10 years ago

Wild Card Domains

I have applied a fix that enables dynroute to update wildcard domains. The bug was being caused by Route53 accepting * but when returning the zone list it would be encoded as \052

Pass Multiple Domains

You can now pass multiple domains to dynroute in a single call.

dynroute -d foo.com -d bar.com

alessioalex commented 10 years ago

Hey @hazanjon thanks so much for the pull request, I'll take a look over it tonight when I get home and merge it if everything's ok.

alessioalex commented 10 years ago

@hazanjon I get this error when running dynroute:

/Users/alexandruvladutu/www/dynroute2/dynroute.js:177
      Name            : details.record.Name,
                                      ^
TypeError: Cannot read property 'Name' of undefined
    at updateDns (/Users/alexandruvladutu/www/dynroute2/dynroute.js:177:39)
    at iterate (/Users/alexandruvladutu/www/dynroute2/dynroute.js:118:20)
    at hostedZones.forEach.rootZone (/Users/alexandruvladutu/www/dynroute2/dynroute.js:99:15)
    at process._tickCallback (node.js:415:13)

Can you please double check, maybe there's something missing in the pull request?

hazanjon commented 10 years ago

Hey @alessioalex, I think I have the problem fixed. The problem was a refactor I made to the updateDns function combined with the adding of multiple domains. This meant that when creating a brand new domain record the function did not actually know what the new domain name was.

The fix is to pass through the current domain being updated so it can be used in the create statement.

alessioalex commented 10 years ago

@hazanjon thanks a lot for the pull request, I have published the new version (0.1.3) to NPM!

alessioalex commented 10 years ago

@hazanjon added you as a contributor to the repo and updated the README.md accordingly:

https://github.com/alessioalex/dynroute#contributors