search

alessiodam / CC-Bank-frontend

The frontend for Bank Of ComputerCraft
https://cc-bank-frontend-tkb-studios.vercel.app
MIT License
1 stars 2 forks source link

React Hook useEffect has a missing dependency: 'fetchTransactions'. Either include it or remove the dependency array. #15

Closed okunamayanad closed 5 months ago

okunamayanad commented 5 months ago

at dashboard/page.tsx:355

Including fetchTransactions in the dependency array triggers more errors. Don't have time to dig into this right now so I'm opening an issue to come back to later.

alessiodam commented 5 months ago

Please update your fork, this isn't in the main nor dev branch here

okunamayanad commented 5 months ago

It's still in the dev branch and I've linked it here. Introduced in #8 when moving fetching transactions to a function. It's not a major problem, but a warning that can cause problems in the future. Please check again using pnpm lint on dev branch.

alessiodam commented 5 months ago

I only see this :/ Screenshot_20240410_181027_Firefox

okunamayanad commented 5 months ago

I only see this :/ Screenshot_20240410_181027_Firefox

That is actually correct behaviour. I've linked that line because it is because of that line. It doesn't have fetchTransactions although it's now fixed by #21