alessiodam / CC-Bank-frontend

The frontend for Bank Of ComputerCraft
https://cc-bank-frontend-tkb-studios.vercel.app
MIT License
1 stars 1 forks source link

Sub navigation bar for dashboard pages #29

Closed Exzotic5485 closed 6 months ago

Exzotic5485 commented 7 months ago

Adds a navbar under the dashboard layout to navigate between the dashboard pages. image

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cc-bank-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 12, 2024 0:29am
okunamayanad commented 7 months ago

Wouldn't it be better to just use the current navbar instead of creating another one?

Exzotic5485 commented 7 months ago

It would work in the current navbar fine but I felt like the dashboard pages should be separate to the rest of the site in case you wanted to add any other public / non authed pages, so the dashboard is sort of in its own section.

okunamayanad commented 7 months ago

It would work in the current navbar fine but I felt like the dashboard pages should be separate to the rest of the site in case you wanted to add any other public / non authed pages, so the dashboard is sort of in its own section.

Great thinking but we currently use the dashboard as a place to put private / authed items. As you said we'll probably need a place to put non authed public pages too. Maybe we should make navbar a place to put public pages, seperate it with a vertical seperator, put only one button for logins and move all private authed items into this subnav. What do you think? also @tkbstudios

Like this: 321981406-f85f1a9a-c5f8-49c3-94a2-f5a40e540861

alessiodam commented 7 months ago

I kinda like it how it is now ngl, have dashboard pages separated from the other navbar

alessiodam commented 6 months ago

@okunamayanad can I merge?

alessiodam commented 6 months ago

Sorry that it took a bit long lol but there u go, the merge :p