search

aleswita / FormRenderer

Form Renderer for Nette Framework and Bootstrap.
MIT License
5 stars 2 forks source link

Compatibility with dev Nette 3.0 #1

Closed Lumeriol closed 6 years ago

Lumeriol commented 6 years ago

Declaration of AlesWita\FormRenderer\BootstrapV4Renderer::renderErrors(?Nette\Forms\IControl $control = NULL, $own = true) must be compatible with Nette\Forms\Rendering\DefaultFormRenderer::renderErrors(?Nette\Forms\IControl $control = NULL, bool $own = true): string

There will be more problems with incompatibility because now it is designed for Nette 2.4.

aleswita commented 6 years ago

Tnx for report. I will fix on Monday. Currently Im on holliday.

aleswita commented 6 years ago

Can you try dev-master version?

Lumeriol commented 6 years ago

Almost done, except missing return type - ": string". After adding it, it should be with fully functional.

And in addition, maybe should be better to use Nette libraries with "use" keyword than write them duplicitously in code?

aleswita commented 6 years ago

Tnx, return type now in dev-master too

aleswita commented 6 years ago

Now is valid the packages settings for install via composer.