search

alesya-h / linux_detect_tablet_mode

Detect if your laptop is in normal or tablet mode. Useful for Yoga laptops to disable keyboard/trackpoint/touchpad in a tablet mode
MIT License
137 stars 29 forks source link

Add Arch AUR link, and add X1 Yoga 3 as a supported device #13

Closed jmarmstrong1207 closed 4 years ago

jmarmstrong1207 commented 4 years ago

This script is useful to me, so I decided to create a package for it in the Arch AUR. Plus, I added my laptop that I use it for.

alesya-h commented 4 years ago

Nice! Thanks :)

Regarding the PKGBUILD there's an issue that it specifies the license as GPL, but this project is actually licenced under MIT.

As a strong suggestion, $USER should be treated as undefined during packaging. Packages are often built in a sandbox, so $USER might be anything really. Or just think that someone might build your PKGBUILD under sudo. The right thing would be to copy an example config into e.g. /etc/detect-tablet-mode/watch_tablet.yml.example and then, after you built and installed the package, copy or symlink the example into your home directory.

Also, from https://wiki.archlinux.org/index.php/Arch_package_guidelines#Directories :

Packages should not contain any of the following directories:

  • ...
  • /home
jmarmstrong1207 commented 4 years ago

Ah, I forgot about not using /home/. I fixed it, changed the license, and it now copies the config file to /etc/. I also added a message for instructions on what to do.

alesya-h commented 4 years ago

👍