Enable Testing for Throws with Helper Function - Githubissues

aletheia-foundation / aletheia-app

Alethia peer to peer publishing platform

http://aletheia-foundation.io/

GNU General Public License v3.0

48 stars 11 forks source link

Enable Testing for Throws with Helper Function #66

Closed cchrs closed 7 years ago

cchrs commented 7 years ago

Implement expectThrow help function from open-zeppelin project
SubmittedPaperIndex throws on empty input
Change test to async/await syntax

I confirm:

[x] I've read the contributing guidelines and the code of conduct
[x] I've checked that this issue applies to this repo
[x] I've checked the existing issues, no one else has reported this
[x] I've limited the subject line to 50 characters
[x] I've capitalised the subject line
[x] I've not ended the subject line with a period
[x] I've used the imperative mood in the subject line

Making an enhancement - ignore this if not making an enhancement

[ ] I've Checked the outstanding issues.
[ ] I've Read the latest version of the whitepaper.
[ ] I've Emailed contact@aletheia-foundation.io to discuss the enhancement.

cchrs commented 7 years ago

Hi, before starting with something real, I had the feeling that there is the need to test easily for throws. I found this functionaly in the openZepplin project which offer also some other interesting functions. Is it ok to use code from other open-source projects like openZepplin? https://github.com/OpenZeppelin/zeppelin-solidity/blob/master/test/helpers/expectThrow.js I think they are under MIT license. I also changed the test file of SubmittedPaperIndex to async/await syntax, hope this is fine. Just let me know if this is ok.