search

aletson / TrinityCore

TrinityCore Open Source MMO Framework
http://www.trinitycore.org
GNU General Public License v2.0
3 stars 1 forks source link

core/scripts: remove stuff from cpp that doesn't need to be there #5

Closed aletson closed 8 years ago

aletson commented 8 years ago

looking through zone_shadowmoon_valley.cpp (although I'm confident other scripts have this as well), stuff like npc_drake_dealer_hurlunk or npc_karynaku could, I believe, be ported into sai easily. this issue is just to remind me to talk to devs about it and make sure that it makes sense to do before I start doing stuff that I shouldn't be doing

aletson commented 8 years ago

after discussing, I think for now it'll be on a case by case basis as I come across them. if I can migrate something, I will.

After #2 is done I'll go through every script and move what I can

ghost commented 8 years ago

That looks like a very good plan. :+1: Enjoy your work on it and don't hesitate to ask if you are uncertain.

Aokromes commented 8 years ago

You can close this now no? :P

ghost commented 8 years ago

I would think it depends on the ambitions expressed in the first post (although not very precise).

edit: looking through PR #17373 again, it does seem to cover this issue pretty well. I'll close it (if you find any reasons it should stay open, it can easily be reopened).

aletson commented 8 years ago

oh okay yeah sorry this wasn't clear, this is kind of just a reminder to me to go through and do more than just gossips, or at least see what else I can do, in every script as I get to them

also to go through the ones that are already done later and review those too