Open aletson opened 6 years ago
all the world stuff is up there, it's all probably easier pickings than the dungeon stuff I'd imagine and a good place to start
Hmm, good question. I don't remember any. Might be worth a try to ask in #trinity if someone there remembers. Then again, we could ask if @Killyana or @dr-j remember any migrations from EscortAI
to smart_scripts
. (BTW, I tried searching the TC repository for commits containing EscortAI
, but all I found was from 2010/2009 and older (ancient and from before SAI was created).
Good point, that SQL looks like a SAI made particularly for an escort purpose.
I have only just begun to look at your 3 linked branches above, it may take a little time to find anything worth commenting on.
can FollowerAI be migrated to SAI?
Perhaps. I would think it could be tied to using the creature_formations
table in connection with waypoints, but I'm not sure about the details and how it works with SAI.
tkrokli https://github.com/TrinityCore/TrinityCore/commit/f9db3940e6cf5d5140067036db119ea248c62378 I converted the injured rainspeaker oracle script too and probably mpre
Thank you, that's a nice example for group movement actions in SAI. Minor detail: the 3.3.5 commit is https://github.com/TrinityCore/TrinityCore/commit/5bfb2a193555f8b16f4bb431c5d8d200d8d0ef78
-- Bartleby SAI
SET @ENTRY := 6090;
UPDATE `creature_template` SET `AIName`="SmartAI" WHERE `entry`=@ENTRY;
DELETE FROM `smart_scripts` WHERE `entryorguid`=@ENTRY AND `source_type`=0;
INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES
(@ENTRY,0,0,0,25,0,100,0,0,0,0,0,2,84,0,0,0,0,0,1,0,0,0,0,0,0,0,"Bartleby - On Reset - Set Faction 84"),
(@ENTRY,0,1,2,19,0,100,0,1640,0,0,0,2,168,0,0,0,0,0,1,0,0,0,0,0,0,0,"Bartleby - On Quest 'Beat Bartleby' Taken - Set Faction 168"),
(@ENTRY,0,2,6,61,0,100,0,0,0,0,0,49,0,0,0,0,0,0,21,100,0,0,0,0,0,0,"Bartleby - On Quest Taken - Start Attacking"),
(@ENTRY,0,3,0,25,0,100,0,0,0,0,0,42,1,0,0,0,0,0,1,0,0,0,0,0,0,0,"Bartleby - On Reset - Set Invincibility Hp 1"),
(@ENTRY,0,4,5,2,0,100,0,0,15,0,0,15,1640,0,0,0,0,0,12,1,0,0,0,0,0,0,"Bartleby - Between 0-15% Health - Quest Credit 'Beat Bartleby'"),
(@ENTRY,0,5,0,61,0,100,0,0,0,0,0,24,0,0,0,0,0,0,1,0,0,0,0,0,0,0,"Bartleby - Between 0-15% Health - Evade"),
(@ENTRY,0,6,0,61,0,100,0,0,0,0,0,64,1,0,0,0,0,0,7,0,0,0,0,0,0,0,"Bartleby - On Quest Taken - Store Targetlist");
@Rushor feel free to open an issue for that if it's good! this is just for documentation and I've been away from the community for a long time
Part of what we need to accomplish as part of this migration is determine what NPC's/GO's are able to be migrated to SAI (no complex scripting, etc) and then start work on these. This is distinct from #7 in that it deals with all NPC's not just those with hardcoded gossip texts.
How to test easily:
.npc add <CreatureID>
.reload creature_template
.reload smart_scripts
.reload condition
.npc add <CreatureID>
World
Eastern Kingdoms
Kalimdor
Outland
Blade's Edge Mountains
Hellfire Peninsula
Nagrand
Netherstorm
Shadowmoon Valley
Zangarmarsh
Northrend
Borean Tundra
Crystalsong Forest
Dalaran
Dragonblight
Grizzly Hills
Howling Fjord
Icecrown
Storm Peaks
Wintergrasp
Holding off until the PR is done.
Zul'Drak
Dungeons
Vanilla
todo
BC
todo
WOTLK
todo
Outstanding Questions