search

aletson / votefinder-web

Web-based vote parser for use on various web forums.
http://votefinder.org
GNU General Public License v3.0
2 stars 1 forks source link

eliminate lambda in VoteCounter.py line 66 #227

Open rjmagley opened 3 years ago

rjmagley commented 3 years ago

lowest possible priority if latest fix fixes the hammer issue but:

not really a bug, but I think line 66 can be replaced with a list comprehension to simplify this code without any significant issues? something in the vein of: executed = [x for x in self.results.items if x['count'] >= to_execute]

possible issue: finding a game where I can test if this actually works? may have to manually create a VoteCounter to test. this may not even be worthwhile. I am cursed for my hubris to wander these desolate fields for all my years

aletson commented 3 years ago

may have to manually create a VoteCounter to test.

204 would fix this, I just need to spin up a xenforo test server or something. I'm hoping my hosting box has capacity.

rjmagley commented 3 years ago

that could be useful, but I just realized with the full DB dump I have I can just make my account the mod of any game I want and manually add whatever votes I want. a dev test forum would definitely be useful, though, especially for if/when game automation happens