alevax / pyviper

Porting of Protein Activity and Pathway Inference to single cell and Python.
MIT License
4 stars 0 forks source link

Default behavior of pyviper.tl.pca #77

Closed LucaZanella15 closed 1 month ago

LucaZanella15 commented 1 month ago

The default behavior of pyviper.tl.pca seems to be different than that of sc.tl.pca. The latter automatically returns the PCA information under the .uns slot, while pyviper returns it when setting copy=False, e.g.:

sc.tl.pca(adata, svd_solver="arpack")

pyviper.tl.pca(adata, svd_solver="arpack", copy=False)

Should copy=False be set as the default in pyviper.tl.pca for consistency with Scanpy?