search

alevy / postgresql-orm

An Haskell ORM (Object Relational Mapping) and migrations DSL for PostgreSQL.
http://simple.cx
GNU General Public License v3.0
78 stars 12 forks source link

Compile with GHC 8 #18

Closed charles-cooper closed 8 years ago

charles-cooper commented 8 years ago

Some updates to the use of GHC 8's Generics API had to be made (cf. https://ghc.haskell.org/trac/ghc/wiki/Migration/8.0).

Fixes https://github.com/alevy/postgresql-orm/issues/17

alevy commented 8 years ago

This, overall seems great to me, However, the build is complaining about AllowAmbiguousTypes. In ernest, I haven't heard of that extension, but if we go forward using it, let's at least make the compiler satisfied :).

charles-cooper commented 8 years ago

That's interesting. It was building fine for me locally using GHC 8 and GHC 7.10 .. looks like travis is using 7.6 somehow. But AllowAmbiguousTypes should have been around in GHC 7.6. Will look into this when I have more time

alevy commented 8 years ago

@charles-cooper this last one seems to be a winner :+1: Can you just clean up the history a bit? Happy for you to override my commits.

charles-cooper commented 8 years ago

Yep, do you mind if i force push?

alevy commented 8 years ago

No not at all... it's your branch!

charles-cooper commented 8 years ago

@alevy how do those commits look?

alevy commented 8 years ago

@charles-cooper yep! awesome!

alevy commented 8 years ago

I'll do a version bump and push to hackage. Do you think this warrants a major(ish) version bump (i.e. to 0.5.0)?

charles-cooper commented 8 years ago

well, it's still compiling with ghc 7.8 so it's not breaking that. it might break earlier versions. my thought would be to bump to 0.5.0 :)