alex-courtis / way-displays

way-displays: Auto Manage Your Wayland Displays
MIT License
267 stars 13 forks source link

Minimum scale would be useful #135

Closed dancek closed 1 year ago

dancek commented 1 year ago

Hi!

I've been a very happy user of way-displays for over a year already. It's the best way of configuring displays I've seen on any platform.

Today I found the first display that I kind of have trouble with: a 27" full HD one. Since the pixels are really big, the autoscale puts me at 0.875 making everything blurry.

I [12:31:01] HDMI-A-1 Changing:
I [12:31:01]   from:
I [12:31:01]     (no mode)
I [12:31:01]     VRR:       off
I [12:31:01]      (disabled)
I [12:31:01]   to:
I [12:31:01]     mode:      1920x1080@60Hz (60,000mHz) (preferred)
I [12:31:01]      (enabled)
I [12:31:02] 
I [12:31:02] Changes successful
I [12:31:02] 
I [12:31:02] HDMI-A-1 Changing:
I [12:31:02]   from:
I [12:31:02]     scale:     1.000 (0.844)
I [12:31:02]     position:  0,0
I [12:31:02]     mode:      1920x1080@60Hz (60,000mHz) (preferred)
I [12:31:02]     VRR:       off
I [12:31:02]   to:
I [12:31:02]     VRR:       on
I [12:31:02] 
I [12:31:02] HDMI-A-1: Cannot enable VRR, display or compositor may not support it.
I [12:31:02] 
I [12:31:02] eDP-1 Changing:
I [12:31:02]   from:
I [12:31:02]     scale:     1.250 (1.682)
I [12:31:02]     position:  0,0
I [12:31:02]     mode:      1920x1200@60Hz (60,001mHz) (preferred)
I [12:31:02]     VRR:       on
I [12:31:02]   to:
I [12:31:02]     position:  329,1234
I [12:31:02] 
I [12:31:02] HDMI-A-1 Changing:
I [12:31:02]   from:
I [12:31:02]     scale:     1.000 (0.844)
I [12:31:02]     position:  0,0
I [12:31:02]     mode:      1920x1080@60Hz (60,000mHz) (preferred)
I [12:31:02]     VRR:       off
I [12:31:02]   to:
I [12:31:02]     scale:     0.875
I [12:31:02] 
I [12:31:02] Changes successful

Of course, a simple way-displays --set SCALE HDMI-A-1 1.0 fixes the issue. But I don't foresee any situation where I'd like a scale less than 1.0, so I'd configure it if I could.

If you think this is a good idea I could implement it and make a PR.

alex-courtis commented 1 year ago

That's a great idea - less than 1 is not a scenario I considered, however it is indeed not desirable.

I'd be most grateful for a PR: https://github.com/alex-courtis/way-displays/blob/master/CONTRIBUTING.md