search

alex-courtis / way-displays

way-displays: Auto Manage Your Wayland Displays
MIT License
252 stars 13 forks source link

Feature: transform the display #43

Closed alex-courtis closed 1 year ago

alex-courtis commented 2 years ago

Closes #41

@anandubey let's continue discussions in here.

anandubey commented 2 years ago

Things left to do:

Thank you for waiting. Last month, I was super occupied at work.

alex-courtis commented 2 years ago

There is a large refactor incoming, which greatly affects cfg.

I am happy to merge it to your repo.

I'll need to have push access... applying a large merge as a patch is not viable.

anandubey commented 2 years ago

I have added you to the collaborators list. I hope now you will have the push access.

alex-courtis commented 2 years ago

I have added you to the collaborators list. I hope now you will have the push access.

Thanks @anandubey

I'll merge master to your fork after https://github.com/alex-courtis/way-displays/tree/49-yaml-schemas is merged.

alex-courtis commented 2 years ago

I'll merge master to your fork after https://github.com/alex-courtis/way-displays/tree/49-yaml-schemas is merged.

master at 1.6.0 has been merged, along with the patches above.

The large change resulted from refactors when adding the IPC API. A lot of src/cfg was moved to src/marshalling

I've pre-emptively added !!transform to the YAML schema You'll need test it with the example client when you have finished adding all the TRANSFORM enums.

alex-courtis commented 2 years ago

Nudge @anandubey

Any updates on this one?

This is really close to complete and I look forward to releasing it!

anandubey commented 2 years ago

@alex-courtis Sorry for zoning out on this. Started my new job on 1st Aug. It's a rust dev role, so all my weekends are going in that. I will try my best to finish it this week.

alex-courtis commented 2 years ago

@alex-courtis Sorry for zoning out on this. Started my new job on 1st Aug. It's a rust dev role, so all my weekends are going in that. I will try my best to finish it this week.

No worries. There is no hurry at all.

Good luck in the new role!

edrex commented 1 year ago

Thanks for your work on this @anandubey, and totally understand about prioritizing paid job.

It would be great to get output transforms in tho. Do you anticipate having time to get this merge ready going forward, or alternatively, would you be open to handing it off?

If C was fresher in my mind I would volunteer (and my ADHD brain likes to say yes) but I shouldn't.

alex-courtis commented 1 year ago

would you be open to handing it off?

That would be fantastic!

I just cannot allocate the time to finish this one off...

If C was fresher in my mind I would volunteer (and my ADHD brain likes to say yes) but I shouldn't.

make cppcheck might be useful to you.

way-displays is also set up for ccls live checking in the editor. Here's my config for neovim lsp: https://github.com/alex-courtis/arch/blob/bd011f38a006cecc2f32526b944d145e164dd7d2/config/nvim/lua/amc/plugins/lsp.lua#L11

edrex commented 1 year ago

make cppcheck

cool!

way-displays is also set up for ccls live checking in the editor.

alright! I use helix which uses clangd by default but I can change it in languages.toml.

alex-courtis commented 1 year ago

alright! I use helix which uses clangd by default but I can change it in languages.toml.

All good; clang is preferred and used by ccls. gcc is only used by default for legacy packaging reasons.

alex-courtis commented 1 year ago

Added development information to https://github.com/alex-courtis/way-displays/blob/master/CONTRIBUTING.md

edrex commented 1 year ago

Want to try to get this in before #83? I would be willing to do a testing pass and make any needed changes if you have time for code review. I think I basically remember how to C :)

I'll be on a road trip/camping Apr 14-23 though, so we'll see how much keyboard time I get.

alex-courtis commented 1 year ago

Want to try to get this in before https://github.com/alex-courtis/way-displays/issues/83? I would be willing to do a testing pass and make any needed changes if you have time for code review. I think I basically remember how to C :)

I'll be on a road trip/camping Apr 14-23 though, so we'll see how much keyboard time I get.

Oh yes please!

I've added a lot of unit tests on master, so that should make this easier RE merge etc.

Edit: Rather than trying to merge this branch it might be easier just to create a new branch and manually copy the relevant bits. Things have changed a lot since this was raised.

alex-courtis commented 1 year ago

133