search

alex-courtis / way-displays

way-displays: Auto Manage Your Wayland Displays
MIT License
240 stars 12 forks source link

test CI compile failure #94

Closed alex-courtis closed 1 year ago

alex-courtis commented 1 year ago

@edrex compile fail messages OK

alex-courtis commented 1 year ago

@edrex test failures look great!

https://github.com/alex-courtis/way-displays/actions/runs/4836898512/jobs/8620384383?pr=95

Question: do we need the push action? On other projects we are just using pull_request...

edrex commented 1 year ago

do we need the push action? On other projects we are just using pull_request

Seems like it comes down to maintainer preference. Merging a branch can combine changes that weren't previously tested together though, so running it on push, at least to the master branch, seems safest. 🤷

alex-courtis commented 1 year ago

do we need the push action? On other projects we are just using pull_request

Seems like it comes down to maintainer preference. Merging a branch can combine changes that weren't previously tested together though, so running it on push, at least to the master branch, seems safest. shrug

That works nicely. Once again many, many thanks for all your work @edrex