Closed senkowo closed 1 month ago
This is great - using a number instead of a boolean is far more flexible!
I'll review tomorrow and sort out the small nits; the readme/man building is fragile and needs a better solution.
Works beautifully, can't break it, valgrind OK.
Would you mind if we moved this new param down, underneath monocle?
--(no-)smart-gaps
--inner-gaps pixels 0 0 <= gap size
--outer-gaps pixels 0 0 <= gap size
--border-width pixels 2 0 <= width
--border-width-monocle pixels 0 0 <= width
--border-width-smart-gaps pixels 0 0 <= gap width
We could also add a note to perhaps the ## GAPS
section, something like:
"For a seamless experience, set this to the same value as --border-width-monocle
."
and make cppcheck returned 21 unused function errors that look pretty similar to
Working fine on CI and my machine, don't stress, cppcheck can behave oddly in different environments.
Works beautifully, can't break it, valgrind OK.
Would you mind if we moved this new param down, underneath monocle?
--(no-)smart-gaps --inner-gaps pixels 0 0 <= gap size --outer-gaps pixels 0 0 <= gap size --border-width pixels 2 0 <= width --border-width-monocle pixels 0 0 <= width --border-width-smart-gaps pixels 0 0 <= gap width
We could also add a note to perhaps the
## GAPS
section, something like:"For a seamless experience, set this to the same value as
--border-width-monocle
."
Both sound good to me!
Many thanks for your contribution! I'm using this right now...
issue #11
I've added a new cli argument
--border-width-smart-gaps
and did everything except generating the readme and man page usingmake doc
(Runningmake doc
results in lots of missing text in the readme, which I think is an issue withmarkdown-toc
on my end and the hacky way I had to install it in...).The new cli argument sets the border width for when smart gaps hides the gaps for all layouts except monocle, and has no effect if
--no-smart-gaps
.Let me know what you think!
TODO:
make test
pass allExtras: results from checks, probably negligible, haven't resolved:
make iwyu
returnedinclude // lines 2-2
make cppcheck
returned 21 unused function errors that look pretty similar tomake test
now passes all tests