alex-courtis / wideriver

GNU General Public License v3.0
34 stars 3 forks source link

Floating window border #15

Open chris977 opened 3 months ago

chris977 commented 3 months ago

Expected behavior

Floating windows should have the border color and width configured in .config/river/init

Actual behavior

A floating window displays the river default border at login or inherits the border (or lack of it) from the previous tag.

Steps to reproduce

At login open a floating window in the first tag. The window has a 2px border with the color #93A1A1 (the river default if other values are not specified). Open a tiling window in tag 2, the window has no borders. Switch back to tag 1, the floating window has now no borders. Open 2 windows in tag 3, the windows have each a 1px border with the configured colors, as expected. Switch back to tag 1, the floating window has now a 1px border with the configured #285577 color.

river version

0.3.4

wideriver version

1.2.0

Startup logs

I [11:10:34] --layout                       left
I [11:10:34] --layout-alt                   monocle
I [11:10:34] --stack                        even
I [11:10:34] --count-master                 1
I [11:10:34] --ratio-master                 0.5
I [11:10:34] --count-wide-left              0
I [11:10:34] --ratio-wide                   0.5
I [11:10:34] --smart-gaps
I [11:10:34] --inner-gaps                   0
I [11:10:34] --outer-gaps                   0
I [11:10:34] --border-width                 1
I [11:10:34] --border-width-monocle         0
I [11:10:34] --border-width-smart-gaps      0
I [11:10:34] --border-color-focused         0x285577
I [11:10:34] --border-color-focused-monocle 0xB48EAD
I [11:10:34] --border-color-unfocused       0x4C566A
I [11:10:34] --log-threshold                info
I [11:10:34] wideriver started
alex-courtis commented 3 months ago

Honestly, I did not consider floating windows; they're not something I use.

Right now it is not possible to set individual borders per window.

It may be possible to set an alternate border scheme when there is a floating window. Detect this via the river status protocol or however lswt does it, looks like wayland protocol.

alex-courtis commented 3 months ago

Draft:

I [11:10:34] --border-width-float         3
I [11:10:34] --border-color-focused-float 0xABBCC
I [11:10:34] --border-color-unfocused       0x4C566A
Anachron commented 2 months ago

I would love to have this feature as well.

Floating Windows are great for sticking views.