alex-courtis / wideriver

GNU General Public License v3.0
33 stars 3 forks source link

Border colour / width #5

Closed Flapper01 closed 5 months ago

Flapper01 commented 6 months ago

I use tags in river like workspaces. I have tags 1 & 3 layout left, 2 and 4 are monocle. The border colour (yellowish) and width (3) are shown on tag 1 but not on tag 3? Tag 3 appears to have no border at all. Otherwise no problems, works great!

river -version
0.3.0-dev.293+b77b42f

Entire log:

I [16:59:53] --layout                       left
I [16:59:53] --layout-alt                   monocle
I [16:59:53] --stack                        dwindle
I [16:59:53] --count-master                 1
I [16:59:53] --ratio-master                 0.6
I [16:59:53] --count-wide-left              0
I [16:59:53] --ratio-wide                   0.35
I [16:59:53] --border-width                 3
I [16:59:53] --border-width-monocle         0
I [16:59:53] --border-color-focused         0x9ba03b
I [16:59:53] --border-color-focused-monocle 0x586e75
I [16:59:53] --border-color-unfocused       0x586e75
I [16:59:53] --log-threshold                info
I [16:59:53] wideriver started

and I switch between layouts as follows: riverctl map normal Super T send-layout-cmd wideriver "--layout-toggle"

alex-courtis commented 6 months ago

Your configuration looks correct. I'm able see the yellow borders on 3, however I'm clearly not replicating correctly:

Perhaps you could make a recording of your session and note the actions you take.

wf-recorder works nicely, capturing the entire screen.

alex-courtis commented 6 months ago

FYI there is an issue which prevents the layout name from updating when you switch to an empty workspace. I'm constantly confused by that.

https://github.com/alex-courtis/wideriver?tab=readme-ov-file#name-does-not-always-update

Flapper01 commented 6 months ago

Thank you for your reply. I have followed your steps below, and I see yellow borders on tag 3, when I open a terminal. I think I may not have identified the problem correctly though. I only see borders on a terminal, not on a browser, or text editor etc.

I think the issue is that borders only work if I use server-side decorations for the view (or a terminal like alacritty which does not have any sort of decoration). Solved (for me anyway). (I tried replying to your email, not sure if you received it)

alex-courtis commented 5 months ago

Great find, many thanks!

Added to quick start and faq: https://github.com/alex-courtis/wideriver?tab=readme-ov-file#quick-start https://github.com/alex-courtis/wideriver?tab=readme-ov-file#borders-are-not-shown

Closing this one, please reopen or comment if you have any further questions.