connormcmk
commented
1 year ago After further inspection, it seems the issue might be coming from the data structures being different in the responses from v1 and v2 farcaster
With an `all-casts-in-thread` query:
```javascript import axios from 'axios'; const options = { method: 'GET', url: 'https://api.neynar.com/v1/farcaster/all-casts-in-thread', params: { api_key: 'NEYNAR_API_DOCS', threadHash: '0xfe90f9de682273e05b201629ad2338bdcd89b6be', viewerFid: '194' }, headers: {accept: 'text/plain'} }; ``` It returns: ```json { "result": { "casts": [ ... { "hash": "0xfe90f9de682273e05b201629ad2338bdcd89b6be", "parentHash": null, "parentUrl": null, "parentAuthor": { "fid": null }, "author": { "fid": 358, "custodyAddress": "0x3bcadeaef7f8e3bf5ec9ca5212cc9c72556c43ed", "username": "corbin.eth", "displayName": "Corbin Page", "pfp": { "url": "https://res.cloudinary.com/merkle-manufactory/image/fetch/c_fill,f_png,w_256/https://lh3.googleusercontent.com/szIk2U62Zfaux7eK8tinvy9vCUz2EPDUYet8WDKN9_dCJmm2-JM8Fux7_Cy2ZWzE9h2g3dIL9j_ywn8iK_UZYB0sToZ1dcP0QBsmh2w" }, "profile": { "bio": { "text": "🏗️ web3 builder\n 🩹 patchwallet.com\n 🧹 dustsweeper.xyz\n 🌐 nf.td/corbin", "mentions": [] } }, "followerCount": 5952, "followingCount": 318, "verifications": [ "0x869ec00fa1dc112917c781942cc01c68521c415e" ], "activeStatus": "active" }, "text": "Banger of a podcast with @pmarca on Rogan!\n\n* Best framing of the dangers of an AI regulatory moat, comparing to Dodd Frank\n* Examples of AI for kids/future gens \n* Cults aren’t all bad \n\nhttps://open.spotify.com/episode/3EWIFUOpaM9s7Pmei0r2C3?si=0xedN1QfTiuMZLAY0cBxlA&context=spotify%3Ashow%3A4rOoJ6Egrf8K2IrywzwOMk", "timestamp": "2023-07-20T00:03:23.000Z", "embeds": [ { "url": "https://open.spotify.com/episode/3EWIFUOpaM9s7Pmei0r2C3?si=0xedN1QfTiuMZLAY0cBxlA&context=spotify%3Ashow%3A4rOoJ6Egrf8K2IrywzwOMk" } ], "reactions": { "count": 5, "fids": [ 124, 8470, 1600, 616, 3 ] }, "recasts": { "count": 1, "fids": [ 714 ] }, "recasters": [ "ryanrodenbaugh" ], "viewerContext": { "liked": false, "recasted": false }, "replies": { "count": 2 }, "threadHash": null }, ... ] } } ```Whereas with v2 return cast:
```javascript const options = { method: 'GET', headers: {accept: 'application/json', api_key: 'NEYNAR_API_DOCS'} }; fetch('https://api.neynar.com/v2/farcaster/cast?type=url', options) .then(response => response.json()) .then(response => console.log(response)) .catch(err => console.error(err)); ``` it returns: ```json { "cast": { "hash": "0x4425780bf8bc68a6422d4cb440b9ca4ba5617c3f", "thread_hash": null, "parent_hash": "0x6663bea5d2b5fdb94682c47b2a5d4f496d22e3cc", "parent_url": null, "parent_author": { "fid": "2588" }, "author": { "fid": 302, "custody_address": "0xa4b7c9173ff5be5c116d2ff846d23dd12a3cc5ec", "username": "gt", "display_name": "Goksu Toprak", "pfp_url": "https://lh3.googleusercontent.com/gq7_KZeGTW4TRQvQx1QhYJvCX0A7AjW8i7VBc8d9vhtaB3xZRS51AEK5pIlb_dL4jpXQ75h_LwMLtf4Jrzuret7DegPfLedEh8mr", "profile": { "bio": { "text": "Working on Farcaster.", "mentions": [] } }, "follower_count": 6065, "following_count": 391, "verifications": [ "0x8ed9eee4fce8cbc92dc4aafbc36b5721eb66b15d" ], "active_status": "active" }, "text": "Go style spec has this right imo: https://google.github.io/styleguide/go/decisions#variable-names", "timestamp": "2023-10-21T18:57:06.000Z", "embeds": [], "reactions": { "likes": [ { "fid": 474 }, { "fid": 834 }, { "fid": 2588 } ], "recasts": [] }, "replies": { "count": 1 } } } ```And with v1 return cast:
```javascript const options = { method: 'GET', headers: {accept: 'application/json', api_key: 'NEYNAR_API_DOCS'} }; fetch('https://api.neynar.com/v1/farcaster/cast?hash=0xfe90f9de682273e05b201629ad2338bdcd89b6be', options) .then(response => response.json()) .then(response => console.log(response)) .catch(err => console.error(err)); ``` It returns: ```json { "result": { "cast": { "hash": "0xfe90f9de682273e05b201629ad2338bdcd89b6be", "parentHash": null, "parentUrl": null, "parentAuthor": { "fid": null }, "author": { "fid": 358, "custodyAddress": "0x3bcadeaef7f8e3bf5ec9ca5212cc9c72556c43ed", "username": "corbin.eth", "displayName": "Corbin Page", "pfp": { "url": "https://res.cloudinary.com/merkle-manufactory/image/fetch/c_fill,f_png,w_256/https://lh3.googleusercontent.com/szIk2U62Zfaux7eK8tinvy9vCUz2EPDUYet8WDKN9_dCJmm2-JM8Fux7_Cy2ZWzE9h2g3dIL9j_ywn8iK_UZYB0sToZ1dcP0QBsmh2w" }, "profile": { "bio": { "text": "🏗️ web3 builder\n 🩹 patchwallet.com\n 🧹 dustsweeper.xyz\n 🌐 nf.td/corbin", "mentions": [] } }, "followerCount": 5952, "followingCount": 318, "verifications": [ "0x869ec00fa1dc112917c781942cc01c68521c415e" ], "activeStatus": "active" }, "text": "Banger of a podcast with @pmarca on Rogan!\n\n* Best framing of the dangers of an AI regulatory moat, comparing to Dodd Frank\n* Examples of AI for kids/future gens \n* Cults aren’t all bad \n\nhttps://open.spotify.com/episode/3EWIFUOpaM9s7Pmei0r2C3?si=0xedN1QfTiuMZLAY0cBxlA&context=spotify%3Ashow%3A4rOoJ6Egrf8K2IrywzwOMk", "timestamp": "2023-07-20T00:03:23.000Z", "embeds": [ { "url": "https://open.spotify.com/episode/3EWIFUOpaM9s7Pmei0r2C3?si=0xedN1QfTiuMZLAY0cBxlA&context=spotify%3Ashow%3A4rOoJ6Egrf8K2IrywzwOMk" } ], "reactions": { "count": 5, "fids": [ 124, 8470, 1600, 616, 3 ] }, "recasts": { "count": 1, "fids": [ 714 ] }, "recasters": [ "ryanrodenbaugh" ], "replies": { "count": 2 }, "threadHash": null } } } ```You can see that for the v1 farcaster endpoint (of which all-casts-in-thread is a member) it returns:
"reactions": {
"likes": [
{ "fid": 474 },
...
],
"recasts": [
{"fid": 454}
]
},Whereas for v2 endpoint it returns:
"reactions": {
"count": 5,
"fids": [
124,
...
]
},It would probably be ideal to map these two return types to the same datastructure. I recommend using the v2 data structure for now:
type Cast = {
hash: Hash;
thread_hash: Hash | null;
parent_hash: Hash | null;
parent_url: string | null;
parent_author: {
fid: number | null;
};
author: {
fid: number;
username: string;
display_name: string;
pfp_url: string;
profile: {
bio: {
text: string;
};
};
follower_count: number;
following_count: number;
verifications: Hash[];
active_status: 'active';
};
text: string;
timestamp: string;
embeds: Embed[];
reactions: {
likes: Like[];
recasts: Recast[];
};
replies: {
count: number;
};
}
alex-grover
Describe the bug The return type of getCastsInThread is:
However, the actual internal values of
result.castsisWhat's expected instead is a structure matching the Cast type, like this: