alex-hhh / data-frame

A data frame implementation for Racket
https://alex-hhh.github.io/2018/08/racket-data-frame-package.html
Other
37 stars 10 forks source link

add ! to functions mutating a data frame #5

Closed ralsei closed 3 years ago

ralsei commented 3 years ago

Pretty much as the title suggests. Old function names are preserved, for compatibility's sake.

There doesn't appear to be a contract-out or provide/contract form that helps with regards to duplicating the contract at the end.

alex-hhh commented 3 years ago

I like this change and it will make the names more consistent, however, I would like some changes:

(provide
 (rename df-put-property! df-put-property (-> data-frame? symbol? any/c any/c))
 (rename df-del-property! df-del-property (-> data-frame? symbol? any/c))
 ;; .. and the rest
)
ralsei commented 3 years ago

Updated function names internally, and all tests passed on my machine with the provide/contract blocks at the end of df.rkt and statistics.rkt commented out. YMMV, but I hope not.

Do let me know if I missed anything.

alex-hhh commented 3 years ago

Thanks for making these changes, I merged the PR.