Type issues when using with storybook that have react dependencies - Githubissues

alex-kinokon / jsx-dom

Use JSX to create DOM elements.

BSD 3-Clause "New" or "Revised" License

277 stars 30 forks source link

Type issues when using with storybook that have react dependencies #66

Closed jung-han closed 3 years ago

jung-han commented 3 years ago

Hi. Thank you for making jsx-dom well. I am developing a video player using jsx-dom.

When I used it before, type inference was done properly by looking at the type of jsx-dom type definition file. But when I use a storybook library like storyshot, I see the react type of this file in jsx-dom.

Do you have any ideas to suggest in this regard?
If jsx-dom is updated to 7.x version, is it okay to develop jsx-dom as the same type as react?(This method seems a bit risky.)

I'm sorry I can't show you the project.

version

jsx-dom: 6.4.23
@storybook/addon-storyshots: 6.3.7

jung-han commented 3 years ago

After updating jsx-dom to 7.x version, change jsxImportSource to jsx-dom, and type works properly.