#40 Docker integration

[marcelovani]

Here is the docker integration. Please try. Run make up build crawl open

[marcelovani]

@iainp999 I only tested on one machine, I would be interested to know if it works fine for you

[iainp999]

@iainp999 I only tested on one machine, I would be interested to know if it works fine for you

Sure, let me add your repo as a remote and check the branch

[iainp999]

@iainp999 I only tested on one machine, I would be interested to know if it works fine for you

Sure, let me add your repo as a remote and check the branch

@marcelovani looks great.

Only minor comments

• If the container isn't running, then make crawl fails i.e. there is no dependency on up - do we want this?
• Similarly - should make open depend on make up?

[marcelovani]

I don't know if this can be done with Makefiles. To achieve that we would need to write some bash scripts to add checks...

[marcelovani]

Or we could create one command that does all

[iainp999]

@marcelovani https://www.tutorialspoint.com/makefile/makefile_dependencies.htm

[marcelovani]

I didn't know we could do that, cool

[marcelovani]

Did a new commit, I added dependencies on build too

[iainp999]

Thanks @marcelovani !

[alex-moreno]

I love it @marcelovani, Vagrant takes a few good 10 or so minutes to build first time. I was up and running in less than 2 minutes, including reading your Readme on how to do it 🥇 😲 ❤️ 👍