alex-oleshkevich / mailers

Email delivery for asyncio.
MIT License
22 stars 1 forks source link

build: 🛠 allow anyio = ">=3.7.1,<5" #2

Closed wolfskaempf closed 7 months ago

wolfskaempf commented 7 months ago

Summary of the changes

Motivation

Hi @alex-oleshkevich,

thank you for making mailers! In my project I have a dependency on starlette-testclient that relies on anyio of major version 3. mailers currently requires anyio = "^4" and I can therefore not use it together with starlette-testclient (apart from heavily complicating my testing setup by splitting everything into separate virtual environments).

As far as I can tell the only method from anyio that is being used in mailers is open_file in mailers/message.py and mailers/transports/file.py. I have checked the anyio changelog to ensure that open_file did not receive any breaking changes between major version 3 and 4 and could not find any mention of breaking changes to that method. The unit tests are also still passing for both version 3.7.1 of anyio and of course major version 4 as currently inside the pyproject.toml.

Therefore I would like to propose with this Pull Request that mailers changes the version definition of anyio in pyproject.toml from anyio = "^4" to anyio = ">=3.7.1,<5".

Please let me know what you think :)

Greetings and best wishes, Athena

alex-oleshkevich commented 7 months ago

merged & released. thanks!

wolfskaempf commented 7 months ago

Thank you for the fast response and release :)