search

alex-oleshkevich / starception

Beautiful exception page for Starlette apps.
MIT License
97 stars 6 forks source link

Release 1.0 in November #13

Closed alex-oleshkevich closed 2 years ago

alex-oleshkevich commented 2 years ago

Take 1 month and if no issues found release 1.0.

euri10 commented 2 years ago

I've been using it extensively since and just found inadvertantly that little template error, I think this is ready

alex-oleshkevich commented 2 years ago

I am in doubt about theme switch button. Currently, it shows the next theme in the chain, not current. Looks like it is a bit confusing. Does it make sense to show current theme icon?

euri10 commented 2 years ago

I am in doubt about theme switch button. Currently, it shows the next theme in the chain, not current. Looks like it is a bit confusing. Does it make sense to show current theme icon?

I have to admit I didnt know that there was a theme switcher, after looking at it I think it's more natural to display current vs next, but that's a matter of taste I suppose, nothhing that should prevent a release :)

alex-oleshkevich commented 2 years ago

Done! Time to open a few beers :)

euri10 commented 2 years ago

Done! Time to open a few beers :)

well deserved it's been a pleasure to develop with it !