alex-oleshkevich / starception

Beautiful exception page for Starlette apps.
MIT License
96 stars 6 forks source link

Add Python 3.7 support #14

Closed jtraub closed 1 year ago

jtraub commented 1 year ago

FastAPI, Starlite and Starlette itself support Python 3.7 while Starception doesn't. This is really sad since I would love to use it in my FastAPI/Starlite extension but I can not narrow down version support.

3.7 is still a supported version receiving security fixes. The support ends in about 8 months (2023-06-27)

So this PR adds Python 3.7 support which basically means:

Also I fixed pre-commit hook config by removing language version restriction on black and using pytest from poetry env (I don't have pytest globally installed on my machine - hence it was failing). Please let me know if I should revert pre-commit hooks

alex-oleshkevich commented 1 year ago

Nice feature! Will test it soon and merge if all goes ok.