alex-oleshkevich / starception

Beautiful exception page for Starlette apps.
MIT License
96 stars 6 forks source link

Fix frame switching in exception chains #16

Closed jtraub closed 1 year ago

jtraub commented 1 year ago

Frame switching doesn't work properly with exception chains

Video highlighting the problem https://user-images.githubusercontent.com/153191/196199576-3c2f83c8-4ad5-4841-8496-ceef65732522.mp4

When a new frame is selected JS hides the very first open code snippet and reveals snippet corresponding to the selected frame. It works fine when there is only one stack trace on the page or when you pick frames from the very first stack trace.

Solution is simple:

Video showing the fix https://user-images.githubusercontent.com/153191/196199935-9c3581b4-4c22-4af3-bb15-d7dddd819edf.mp4