search

alex-oleshkevich / vue-tabler-icons

Fully customizable free SVG icons made as Vue components.
MIT License
150 stars 13 forks source link

Make vue-tabler-icons compatible with vue 3 #8

Closed liebsoer closed 3 years ago

liebsoer commented 3 years ago

Hi :)

while working on vue 3 project I recognized that your awesome vue-tabler-icons aren't compatible with vue 3 because of some Vue 3 API changes.

So I updated your build script and now it's working fine with Vue 3.

In my fork I did the work in a dedicated branch. But because you have only a master branch, I can't create the PR agains another branch. My suggestion is that my changes are integrated in another brunch. I think for Vue 3 it makes sense to publish it as an own module. I already added a vue3 postfix to the module name in the package.json for that.

alex-oleshkevich commented 3 years ago

Wow, thank you a lot! I was thinking about this as well. I plan to publish Vue 3-only v2.0 version and maintain v1.0 for Vue 2.

alex-oleshkevich commented 3 years ago

Hey @liebsoer , thank you for your work! It has been included in release 2.0.